Initial Kinetis pinctrl Implementation #43033
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieldegrasse
requested review from
dleach02,
gmarull and
mmahadevan108
as code owners
github-actions
bot
added
area: Boards
area: Devicetree
area: Devicetree Binding
29 tasks
gmarull
reviewed
Feb 21, 2022
Member
gmarull
left a comment
gmarull
left a comment
There was a problem hiding this comment.
Overall LGTM, I have some minor comments
zephyrbot
added
area: UART
zephyrbot
requested review from
SebastianBoe,
dcpleung,
galak,
nashif and
tejlmand
gmarull
previously approved these changes
Feb 26, 2022
Member
gmarull
left a comment
gmarull
left a comment
There was a problem hiding this comment.
LGTM, I have a few minor questions/suggestions.
github-actions
bot
added
manifest
west
manifest-hal_nxp
DNM
|
The following west manifest projects have been modified in this Pull Request:
Note: This message is automatically posted and updated by the Manifest GitHub Action. |
gmarull
previously approved these changes
Mar 1, 2022
NXP hal pinctrl header files are required for pin groups. Update HAL revision to pull in pinctrl header files. Signed-off-by: Daniel DeGrasse <[email protected]>
Add pinctrl include file to define SOC specific pinctrl_soc_t structure, used to store pin configuration for pinctrl driver Signed-off-by: Daniel DeGrasse <[email protected]>
Add kinetis pinctrl driver. Driver initializes clocks for each port, and exposes the pinctrl_configure_pins function required for pinctrl support. Signed-off-by: Daniel DeGrasse <[email protected]>
Add pinctrl node group bindings for kinetis MCUs Signed-off-by: Daniel DeGrasse <[email protected]>
Kinetis pinctrl groups need dummy pinctrl node to populate with pinctrl options at the board level. Add one in each Signed-off-by: Daniel DeGrasse <[email protected]>
Add pinctrl support to mcux uart driver Signed-off-by: Daniel DeGrasse <[email protected]>
Add board level pin group definitions, and remove uart pinmux driver calls. pinctrl is enabled for uart driver Signed-off-by: Daniel DeGrasse <[email protected]>
Add pinctrl nodes for frdm_kw41z Signed-off-by: Daniel DeGrasse <[email protected]>
Add pinctrl groups for hexiwear_k64, and enable pinctrl Signed-off-by: Daniel DeGrasse <[email protected]>
Enable pinctrl for hexiwear kw40z target Signed-off-by: Daniel DeGrasse <[email protected]>
Add pinctrl groups for ip_k66f Signed-off-by: Daniel DeGrasse <[email protected]>
Add pinctrl nodes for frdm_k22f Signed-off-by: Daniel DeGrasse <[email protected]>
Add pinctrl groups for frdm_k82f Signed-off-by: Daniel DeGrasse <[email protected]>
Add pinctrl groups for frdm_kl25z Signed-off-by: Daniel DeGrasse <[email protected]>
Add pinctrl groups for rddrone_fmuk66 Signed-off-by: Daniel DeGrasse <[email protected]>
Add pinctrl groups for twr_ke18f Signed-off-by: Daniel DeGrasse <[email protected]>
Add pinctrl groups for twr_kv58f220m Signed-off-by: Daniel DeGrasse <[email protected]>
Add pinctrl groups for usb_kw24d512 Signed-off-by: Daniel DeGrasse <[email protected]>
SOC specific wrapper files were used to include pinctrl DTSI files. Remove these in favor of including pinctrl header files directly from board pinctrl definitions. Signed-off-by: Daniel DeGrasse <[email protected]>
Contributor
|
@gmarull please re-approve |
Contributor
|
@dleach02 @mmahadevan108 please review |
gmarull
approved these changes
Mar 2, 2022
dleach02
approved these changes
Mar 3, 2022
dleach02
approved these changes
Mar 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an initial implementation of pinctrl for kinetis series MCUs, with the UART driver enabled. It is based on the work in #39743, but uses a pin group based approach instead of pin nodes. Pin mux configurations are defined at the SOC level as constant values, and these values are referenced in the pin groups in order to select pin mux options.